build: drop unconditional openssl dep from cctest#7486
build: drop unconditional openssl dep from cctest#7486bnoordhuis merged 1 commit intonodejs:masterfrom
Conversation
bnoordhuis
added
build
|
LGTM if CI is green. Do we skip the cc tests in that case? |
|
No, just the inspector cctests. |
|
That's what I meant to ask 😄 Thanks for the clarification |
|
LGTM pending CI |
|
LGTM |
Don't link in openssl when building `./configure --without-inspector`, it's only used by the inspector cctests. Ditto libuv and http_parser. Fixes unnecessarily building openssl when `--shared-openssl` is also passed to configure. Fixes: nodejs#7478 PR-URL: nodejs#7486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@thealphanerd Apologies, I forgot to add you as a reviewer. |
|
Yes, thanks, that works with fixing it when v8_inspector is disabled. But what about the case when it's enabled, and Would wrapping all those deps inside of |
|
Virtual shrug. Of course it could be made to work but since |
|
@bnoordhuis nbd. I've started using https://github.com/evanlucas/core-get-reviewers to simplify things for myself, might be worth checking out. 👍 |
Don't link in openssl when building `./configure --without-inspector`, it's only used by the inspector cctests. Ditto libuv and http_parser. Fixes unnecessarily building openssl when `--shared-openssl` is also passed to configure. Fixes: #7478 PR-URL: #7486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added
dont-land-on-v4.x
inspector
6 participants
Don't link in openssl when building
./configure --without-inspector,it's only used by the inspector cctests. Ditto libuv and http_parser.
Fixes: #7478
CI: https://ci.nodejs.org/job/node-test-pull-request/3131/